Skip to content

Conversation

@supersaiyansubtlety
Copy link
Member

@supersaiyansubtlety supersaiyansubtlety commented Nov 8, 2025

Rewrites Result so it has separate Ok and Err implementations.

Also adds javadocs.

Notably it doesn't hide the Ok and Err implementations; it didn't seem necessary. hid them in package-private classes to be safe
(I'm also not sure if util is part of the api or not)

@supersaiyansubtlety supersaiyansubtlety self-assigned this Nov 8, 2025
@supersaiyansubtlety supersaiyansubtlety added enhancement New feature or request refactor improvements that don't impact functionality labels Nov 8, 2025
@ix0rai ix0rai added the backend affects the enigma backend label Nov 8, 2025
@ix0rai ix0rai self-requested a review November 8, 2025 20:24
@OroArmor
Copy link
Member

OroArmor commented Nov 8, 2025

Me when rust

@ix0rai
Copy link
Member

ix0rai commented Nov 10, 2025

to me util isn't API, we're allowed to break whenever we want. if a util class is worth exposing as API we'll do an api.util package

@supersaiyansubtlety supersaiyansubtlety changed the base branch from develop/2.7 to develop/2.8 November 18, 2025 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend affects the enigma backend enhancement New feature or request refactor improvements that don't impact functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants