Skip to content

Fix tabs #315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 26, 2025
Merged

Fix tabs #315

merged 3 commits into from
Oct 26, 2025
+32 −26

Conversation

@supersaiyansubtlety
Copy link
Member

Fixes two issues I introduced in #296 (sorry about that):

  • NPE when closing the last tab
  • clicking the title label of a tab didn't select the tab

@supersaiyansubtlety supersaiyansubtlety self-assigned this Oct 9, 2025
@supersaiyansubtlety supersaiyansubtlety added bug Something isn't working user interface affects the enigma ui labels Oct 9, 2025
ix0rai
ix0rai approved these changes Oct 13, 2025
View reviewed changes
Copy link
Member

@ix0rai ix0rai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i reallyyyyyy should have caught that NPE testing. thanks for the fixes!

@ix0rai ix0rai merged commit eaaa158 into QuiltMC:develop/2.7 Oct 26, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ix0rai ix0rai ix0rai approved these changes

Assignees

@supersaiyansubtlety supersaiyansubtlety

Labels

bug Something isn't working user interface affects the enigma ui

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@supersaiyansubtlety @ix0rai