Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustable buffer #467

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Fix up bad tests

4507528
Select commit
Loading
Failed to load commit list.
Open

Adjustable buffer #467

Fix up bad tests
4507528
Select commit
Loading
Failed to load commit list.
Xcode Cloud / Decimus | PR | Build - tvOS succeeded Aug 23, 2024 in 8m 2s

109 warnings

Report Summary
Errors 0
Test Failures 0
Analysis Issues 0
Warnings 109

Details

109 Warnings

Details

  Decimus/CMSampleBuffer+Attachments.swift:31
      Vertical Parameter Alignment Violation: Function parameters should be aligned vertically if they're in multiple lines in a declaration (vertical_parameter_alignment)
  Decimus/Views/Components/CallControls.swift:66
      'onChange(of:perform:)' was deprecated in tvOS 17.0: Use `onChange` with a two or zero parameter action closure instead.
  Decimus/Views/Settings/SubscriptionSettingsView.swift:116
      Line Length Violation: Line should be 120 characters or less; currently it has 136 characters (line_length)
  Decimus/Subscriptions/VideoSubscription.swift:168
      Function Body Length Violation: Function body should span 50 lines or less excluding comments and whitespace: currently spans 75 lines (function_body_length)
  Decimus/VideoJitterBuffer.swift:129
      Todo Violation: TODOs should be resolved ((RichLogan): For now, don't ex...) (todo)
  Decimus/Subscriptions/VideoSubscription.swift:354
      Identifier Name Violation: Variable name 'at' should be between 3 and 40 characters long (identifier_name)
  Decimus/Views/InCallView.swift:104
      Blanket Disable Command Violation: Use 'next', 'this' or 'previous' instead to disable the 'force_try' rule once, or re-enable it as soon as possible` (blanket_disable_command)
  Decimus/Codec/H264Utilities.swift:61
      Line Length Violation: Line should be 120 characters or less; currently it has 129 characters (line_length)
  Decimus/Subscriptions/VideoSubscription.swift:168
      Cyclomatic Complexity Violation: Function should have complexity 10 or less; currently complexity is 15 (cyclomatic_complexity)
  Decimus/Codec/VTEncoder.swift:307
      Line Length Violation: Line should be 120 characters or less; currently it has 122 characters (line_length)
  Decimus/Views/Settings/SubscriptionSettingsView.swift:110
      'onChange(of:perform:)' was deprecated in tvOS 17.0: Use `onChange` with a two or zero parameter action closure instead.
  Decimus/Subscriptions/OpusHandler.swift:97
      Line Length Violation: Line should be 120 characters or less; currently it has 149 characters (line_length)
  Decimus/Codec/VTEncoder.swift:226
      Cyclomatic Complexity Violation: Function should have complexity 10 or less; currently complexity is 17 (cyclomatic_complexity)
  Decimus/DecimusAudioEngine.swift:83
      Cyclomatic Complexity Violation: Function should have complexity 10 or less; currently complexity is 12 (cyclomatic_complexity)
  Decimus/Views/Components/CallControls.swift:79
      Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
  Decimus/Codec/H264Utilities.swift:86
      Line Length Violation: Line should be 120 characters or less; currently it has 126 characters (line_length)
  dependencies/new-qmedia/dependencies/libquicr/dependencies/transport/include/transport/safe_queue.h:50
      Empty paragraph passed to '@param' command
  Decimus/Subscriptions/OpusHandler.swift:159
      Todo Violation: TODOs should be resolved (This can be optimized with som...) (todo)
  Decimus/Codec/VTEncoder.swift:75
      Line Length Violation: Line should be 120 characters or less; currently it has 135 characters (line_length)
  Decimus/Codec/VTEncoder.swift:14
      Blanket Disable Command Violation: Use 'next', 'this' or 'previous' instead to disable the 'type_body_length' rule once, or re-enable it as soon as possible` (blanket_disable_command)
  Decimus/Views/InCallView.swift:238
      Line Length Violation: Line should be 120 characters or less; currently it has 121 characters (line_length)
  Decimus/Codec/VTEncoder.swift:226
      Line Length Violation: Line should be 120 characters or less; currently it has 126 characters (line_length)
  Decimus/Views/Components/CallControls.swift:46
      Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
  Decimus/Models/Publication.swift:11
      Todo Violation: TODOs should be resolved (This protocol is redundent.) (todo)
  Decimus/CallController.swift:100
      Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between `String` and `Data` (non_optional_string_data_conversion)
  Decimus/VideoJitterBuffer.swift:6
      Blanket Disable Command Violation: Use 'next', 'this' or 'previous' instead to disable the 'force_cast' rule once, or re-enable it as soon as possible` (blanket_disable_command)
  Decimus/Views/Components/SubscriptionPopover.swift:84
      Line Length Violation: Line should be 120 characters or less; currently it has 130 characters (line_length)
  Decimus/Views/CallSetupView.swift:51
      'onChange(of:perform:)' was deprecated in tvOS 17.0: Use `onChange` with a two or zero parameter action closure instead.
  Decimus/Codec/ApplicationSEIs.swift:84
      Line Length Violation: Line should be 120 characters or less; currently it has 133 characters (line_length)
  Decimus/Subscriptions/VideoSubscription.swift:439
      Line Length Violation: Line should be 120 characters or less; currently it has 143 characters (line_length)
  Decimus/Codec/H264Utilities.swift:67
      Line Length Violation: Line should be 120 characters or less; currently it has 129 characters (line_length)
  Decimus/Views/Settings/SubscriptionSettingsView.swift:33
      'onChange(of:perform:)' was deprecated in tvOS 17.0: Use `onChange` with a two or zero parameter action closure instead.
  Decimus/Views/Components/CallControls.swift:54
      Multiple Closures with Trailing Closure Violation: Trailing closure syntax should not be used when passing more than one closure argument (multiple_closures_with_trailing_closure)
  Decimus/Views/Components/PublicationPopover.swift:64
      'onChange(of:perform:)' was deprecated in tvOS 17.0: Use `onChange` with a two or zero parameter action closure instead.
  Decimus/Subscriptions/VideoSubscription.swift:562
      Cyclomatic Complexity Violation: Function should have complexity 10 or less; currently complexity is 12 (cyclomatic_complexity)
  Decimus/CaptureManager.swift:165
      Function Body Length Violation: Function body should span 50 lines or less excluding comments and whitespace: currently spans 54 lines (function_body_length)
  Decimus/Codec/H264Utilities.swift:4
      Blanket Disable Command Violation: Use 'next', 'this' or 'previous' instead to disable the 'function_body_length' rule once, or re-enable it as soon as possible` (blanket_disable_command)
  Decimus/VideoDequeuer.swift:27
      Identifier Name Violation: Variable name 'kd' should be between 3 and 40 characters long (identifier_name)
  Decimus/VideoJitterBuffer.swift:83
      Reduce Boolean Violation: Use `allSatisfy` instead (reduce_boolean)
  Decimus/Codec/VTEncoder.swift:432
      Line Length Violation: Line should be 120 characters or less; currently it has 151 characters (line_length)
  Decimus/Subscriptions/VideoSubscription.swift:471
      Line Length Violation: Line should be 120 characters or less; currently it has 122 characters (line_length)
  Decimus/Metrics/InfluxMetricsSubmitter.swift:49
      Cyclomatic Complexity Violation: Function should have complexity 10 or less; currently complexity is 12 (cyclomatic_complexity)
  Decimus/Models/ManifestTypes.swift:88
      Todo Violation: TODOs should be resolved (Fix this in manifest to be "qu...) (todo)
  Decimus/Subscriptions/VideoSubscription.swift:323
      Line Length Violation: Line should be 120 characters or less; currently it has 123 characters (line_length)
  Decimus/CaptureManager.swift:424
      File Length Violation: File should contain 400 lines or less: currently contains 424 (file_length)
  Decimus/Codec/H264Utilities.swift:102
      Cyclomatic Complexity Violation: Function should have complexity 10 or less; currently complexity is 13 (cyclomatic_complexity)
  Decimus/VideoJitterBuffer.swift:192
      Todo Violation: TODOs should be resolved (Ensure we cannot enqueue a fra...) (todo)
  Decimus/Views/Components/SubscriptionPopover.swift:92
      Line Length Violation: Line should be 120 characters or less; currently it has 126 characters (line_length)
  Decimus/Codec/ApplicationSEIs.swift:127
      Line Length Violation: Line should be 120 characters or less; currently it has 126 characters (line_length)
  Decimus/DecimusAudioEngine.swift:5
      Type Body Length Violation: Type body should span 250 lines or less excluding comments and whitespace: currently spans 270 lines (type_body_length)
  Decimus/Subscriptions/VideoSubscription.swift:56
      Function Body Length Violation: Function body should span 50 lines or less excluding comments and whitespace: currently spans 68 lines (function_body_length)
  Decimus/Codec/ApplicationSEIs.swift:204
      Line Length Violation: Line should be 120 characters or less; currently it has 125 characters (line_length)
  Decimus/CpuUsage.swift:13
      Initialization of 'UnsafeMutablePointer' (aka 'UnsafeMutablePointer') results in a dangling pointer
  Decimus/Subscriptions/VideoSubscription.swift:562
      Function Body Length Violation: Function body should span 50 lines or less excluding comments and whitespace: currently spans 74 lines (function_body_length)
  Decimus/CaptureManager.swift:358
      Cyclomatic Complexity Violation: Function should have complexity 10 or less; currently complexity is 12 (cyclomatic_complexity)
  Decimus/Publications/H264Publication.swift:116
      Line Length Violation: Line should be 120 characters or less; currently it has 147 characters (line_length)
  Decimus/Publications/H264Publication.swift:58
      Line Length Violation: Line should be 120 characters or less; currently it has 153 characters (line_length)
  Decimus/Subscriptions/OpusHandler.swift:113
      Line Length Violation: Line should be 120 characters or less; currently it has 155 characters (line_length)
  Decimus/Publications/H264Publication.swift:96
      Line Length Violation: Line should be 120 characters or less; currently it has 132 characters (line_length)
  Decimus/Measurements/VideoSubscription+Measurement.swift:37
      Identifier Name Violation: Variable name 'at' should be between 3 and 40 characters long (identifier_name)
  Decimus/Measurements/VideoSubscription+Measurement.swift:42
      Identifier Name Violation: Variable name 'at' should be between 3 and 40 characters long (identifier_name)
  Decimus/VideoDequeuer.swift:16
      Identifier Name Violation: Variable name 'ki' should be between 3 and 40 characters long (identifier_name)
  Decimus/CaptureManager.swift:36
      Type Body Length Violation: Type body should span 250 lines or less excluding comments and whitespace: currently spans 311 lines (type_body_length)
  Decimus/CaptureManager.swift:199
      Todo Violation: TODOs should be resolved (Theoretically all of these may...) (todo)
  Decimus/Subscriptions/VideoSubscription.swift:465
      Line Length Violation: Line should be 120 characters or less; currently it has 160 characters (line_length)
  Decimus/VideoJitterBuffer.swift:42
      Function Body Length Violation: Function body should span 50 lines or less excluding comments and whitespace: currently spans 56 lines (function_body_length)
  Decimus/VideoDequeuer.swift:17
      Identifier Name Violation: Variable name 'kd' should be between 3 and 40 characters long (identifier_name)
  Decimus/Publications/H264Publication.swift:147
      Todo Violation: TODOs should be resolved (This age is probably useless.) (todo)
  Decimus/Views/Components/CallControls.swift:180
      Main actor-isolated static property 'logger' can not be referenced from a non-isolated context; this is an error in Swift 6
  Decimus/Codec/ApplicationSEIs.swift:150
      Line Length Violation: Line should be 120 characters or less; currently it has 131 characters (line_length)
  Decimus/Codec/VTEncoder.swift:93
      Superfluous Disable Command Violation: SwiftLint rule 'switch_case_alignment' did not trigger a violation in the disabled region; remove the disable command (superfluous_disable_command)
  Decimus/Views/Settings/SubscriptionSettingsView.swift:75
      'onChange(of:perform:)' was deprecated in tvOS 17.0: Use `onChange` with a two or zero parameter action closure instead.
  Decimus/Codec/ApplicationSEIs.swift:65
      Line Length Violation: Line should be 120 characters or less; currently it has 122 characters (line_length)
  Decimus/Subscriptions/OpusSubscription.swift:97
      Todo Violation: TODOs should be resolved (Handle sequence rollover.) (todo)
  Decimus/Subscriptions/VideoSubscription.swift:126
      Line Length Violation: Line should be 120 characters or less; currently it has 126 characters (line_length)
  Decimus/Codec/ApplicationSEIs.swift:126
      Line Length Violation: Line should be 120 characters or less; currently it has 121 characters (line_length)
  Decimus/Views/Settings/AppStorageWrapper.swift:16
      Non-Optional String <-> Data Conversion Violation: Prefer using UTF-8 encoded strings when converting between `String` and `Data` (non_optional_string_data_conversion)
  Decimus/Codec/H264Utilities.swift:87
      Line Length Violation: Line should be 120 characters or less; currently it has 128 characters (line_length)
  Decimus/Codec/VTEncoder.swift:542
      File Length Violation: File should contain 400 lines or less: currently contains 542 (file_length)
  Decimus/Publications/OpusPublication.swift:80
      Line Length Violation: Line should be 120 characters or less; currently it has 132 characters (line_length)
  Decimus/Subscriptions/VideoSubscription.swift:419
      Line Length Violation: Line should be 120 characters or less; currently it has 128 characters (line_length)
  Decimus/VideoDequeuer.swift:27
      Identifier Name Violation: Variable name 'kp' should be between 3 and 40 characters long (identifier_name)
  Decimus/Views/InCallView.swift:321
      No calls to throwing functions occur within 'try' expression
  Decimus/DecimusAudioEngine.swift:83
      Function Body Length Violation: Function body should span 50 lines or less excluding comments and whitespace: currently spans 97 lines (function_body_length)
  Decimus/Codec/VTEncoder.swift:457
      Line Length Violation: Line should be 120 characters or less; currently it has 147 characters (line_length)
  Decimus/VideoDequeuer.swift:27
      Identifier Name Violation: Variable name 'ki' should be between 3 and 40 characters long (identifier_name)
  Decimus/Subscriptions/VideoHandler.swift:459
      Line Length Violation: Line should be 120 characters or less; currently it has 152 characters (line_length)
  Decimus/Codec/VTEncoder.swift:314
      Line Length Violation: Line should be 120 characters or less; currently it has 133 characters (line_length)
  Decimus/Codec/HEVCUtilities.swift:32
      Cyclomatic Complexity Violation: Function should have complexity 10 or less; currently complexity is 15 (cyclomatic_complexity)
  Decimus/Codec/ApplicationSEIs.swift:125
      Line Length Violation: Line should be 120 characters or less; currently it has 121 characters (line_length)
  dependencies/new-qmedia/dependencies/libquicr/dependencies/transport/include/transport/transport.h:115
      Implicit conversion loses integer precision: 'rep' (aka 'long long') to 'uint32_t' (aka 'unsigned int')
  Decimus/Models/Publication.swift:16
      Line Length Violation: Line should be 120 characters or less; currently it has 130 characters (line_length)
  Decimus/Subscriptions/VideoHandler.swift:5
      Blanket Disable Command Violation: Use 'next', 'this' or 'previous' instead to disable the 'type_body_length' rule once, or re-enable it as soon as possible` (blanket_disable_command)
  Decimus/Views/Components/SubscriptionPopover.swift:91
      'onChange(of:perform:)' was deprecated in tvOS 17.0: Use `onChange` with a two or zero parameter action closure instead.
  Decimus/CMSampleBuffer+Attachments.swift:41
      Line Length Violation: Line should be 120 characters or less; currently it has 139 characters (line_length)
  Decimus/Views/InCallView.swift:322
      'catch' block is unreachable because no errors are thrown in 'do' block
  Decimus/Views/InCallView.swift:119
      Invalid SwiftLint Command Violation: swiftlint command does not have a valid modifier (invalid_swiftlint_command)
  Decimus/Subscriptions/VideoSubscription.swift:340
      Line Length Violation: Line should be 120 characters or less; currently it has 143 characters (line_length)
  Decimus/CMSampleBuffer+Attachments.swift:32
      Vertical Parameter Alignment Violation: Function parameters should be aligned vertically if they're in multiple lines in a declaration (vertical_parameter_alignment)
  dependencies/new-qmedia/dependencies/libquicr/dependencies/transport/include/transport/safe_queue.h:165
      '@return' command used in a comment that is attached to a function returning void
  Decimus/VideoDequeuer.swift:15
      Identifier Name Violation: Variable name 'kp' should be between 3 and 40 characters long (identifier_name)
  Decimus/Publications/PublicationFactory.swift:37
      Todo Violation: TODOs should be resolved (SourceID from manifest is bogu...) (todo)
  Decimus/Subscriptions/VideoSubscription.swift:649
      File Length Violation: File should contain 400 lines or less: currently contains 649 (file_length)
  Decimus/Views/InCallView.swift:291
      Line Length Violation: Line should be 120 characters or less; currently it has 129 characters (line_length)
  Decimus/CaptureManager.swift:109
      Instance methods of non-Sendable types cannot be marked as '@Sendable'; this is an error in Swift 6
  Decimus/Subscriptions/VideoHandler.swift:506
      File Length Violation: File should contain 400 lines or less: currently contains 506 (file_length)
  Decimus/Views/Components/PublicationPopover.swift:65
      Line Length Violation: Line should be 120 characters or less; currently it has 125 characters (line_length)
  Decimus/Subscriptions/OpusSubscription.swift:67
      Line Length Violation: Line should be 120 characters or less; currently it has 131 characters (line_length)
  Decimus/Codec/ApplicationSEIs.swift:64
      Line Length Violation: Line should be 120 characters or less; currently it has 124 characters (line_length)

Annotations

Check notice on line 116 in Decimus/Views/Settings/SubscriptionSettingsView.swift

See this annotation in the file changed.

@xcode-cloud xcode-cloud / Decimus | PR | Build - tvOS

Decimus/Views/Settings/SubscriptionSettingsView.swift#L116 

Line Length Violation: Line should be 120 characters or less; currently it has 136 characters (line_length)

Check notice on line 168 in Decimus/Subscriptions/VideoSubscription.swift

See this annotation in the file changed.

@xcode-cloud xcode-cloud / Decimus | PR | Build - tvOS

Decimus/Subscriptions/VideoSubscription.swift#L168 

Function Body Length Violation: Function body should span 50 lines or less excluding comments and whitespace: currently spans 75 lines (function_body_length)

Check notice on line 129 in Decimus/VideoJitterBuffer.swift

See this annotation in the file changed.

@xcode-cloud xcode-cloud / Decimus | PR | Build - tvOS

Decimus/VideoJitterBuffer.swift#L129 

Todo Violation: TODOs should be resolved ((RichLogan): For now, don't ex...) (todo)

Check notice on line 354 in Decimus/Subscriptions/VideoSubscription.swift

See this annotation in the file changed.

@xcode-cloud xcode-cloud / Decimus | PR | Build - tvOS

Decimus/Subscriptions/VideoSubscription.swift#L354 

Identifier Name Violation: Variable name 'at' should be between 3 and 40 characters long (identifier_name)

Check notice on line 168 in Decimus/Subscriptions/VideoSubscription.swift

See this annotation in the file changed.

@xcode-cloud xcode-cloud / Decimus | PR | Build - tvOS

Decimus/Subscriptions/VideoSubscription.swift#L168 

Cyclomatic Complexity Violation: Function should have complexity 10 or less; currently complexity is 15 (cyclomatic_complexity)

Check notice on line 110 in Decimus/Views/Settings/SubscriptionSettingsView.swift

See this annotation in the file changed.

@xcode-cloud xcode-cloud / Decimus | PR | Build - tvOS

Decimus/Views/Settings/SubscriptionSettingsView.swift#L110 

'onChange(of:perform:)' was deprecated in tvOS 17.0: Use `onChange` with a two or zero parameter action closure instead.

Check notice on line 6 in Decimus/VideoJitterBuffer.swift

See this annotation in the file changed.

@xcode-cloud xcode-cloud / Decimus | PR | Build - tvOS

Decimus/VideoJitterBuffer.swift#L6 

Blanket Disable Command Violation: Use 'next', 'this' or 'previous' instead to disable the 'force_cast' rule once, or re-enable it as soon as possible` (blanket_disable_command)

Check notice on line 439 in Decimus/Subscriptions/VideoSubscription.swift

See this annotation in the file changed.

@xcode-cloud xcode-cloud / Decimus | PR | Build - tvOS

Decimus/Subscriptions/VideoSubscription.swift#L439 

Line Length Violation: Line should be 120 characters or less; currently it has 143 characters (line_length)

Check notice on line 33 in Decimus/Views/Settings/SubscriptionSettingsView.swift

See this annotation in the file changed.

@xcode-cloud xcode-cloud / Decimus | PR | Build - tvOS

Decimus/Views/Settings/SubscriptionSettingsView.swift#L33 

'onChange(of:perform:)' was deprecated in tvOS 17.0: Use `onChange` with a two or zero parameter action closure instead.

Check notice on line 562 in Decimus/Subscriptions/VideoSubscription.swift

See this annotation in the file changed.

@xcode-cloud xcode-cloud / Decimus | PR | Build - tvOS

Decimus/Subscriptions/VideoSubscription.swift#L562 

Cyclomatic Complexity Violation: Function should have complexity 10 or less; currently complexity is 12 (cyclomatic_complexity)

Check notice on line 83 in Decimus/VideoJitterBuffer.swift

See this annotation in the file changed.

@xcode-cloud xcode-cloud / Decimus | PR | Build - tvOS

Decimus/VideoJitterBuffer.swift#L83 

Reduce Boolean Violation: Use `allSatisfy` instead (reduce_boolean)

Check notice on line 471 in Decimus/Subscriptions/VideoSubscription.swift

See this annotation in the file changed.

@xcode-cloud xcode-cloud / Decimus | PR | Build - tvOS

Decimus/Subscriptions/VideoSubscription.swift#L471 

Line Length Violation: Line should be 120 characters or less; currently it has 122 characters (line_length)

Check notice on line 323 in Decimus/Subscriptions/VideoSubscription.swift

See this annotation in the file changed.

@xcode-cloud xcode-cloud / Decimus | PR | Build - tvOS

Decimus/Subscriptions/VideoSubscription.swift#L323 

Line Length Violation: Line should be 120 characters or less; currently it has 123 characters (line_length)

Check notice on line 192 in Decimus/VideoJitterBuffer.swift

See this annotation in the file changed.

@xcode-cloud xcode-cloud / Decimus | PR | Build - tvOS

Decimus/VideoJitterBuffer.swift#L192 

Todo Violation: TODOs should be resolved (Ensure we cannot enqueue a fra...) (todo)

Check notice on line 649 in Decimus/Subscriptions/VideoSubscription.swift

See this annotation in the file changed.

@xcode-cloud xcode-cloud / Decimus | PR | Build - tvOS

Decimus/Subscriptions/VideoSubscription.swift#L649 

File Length Violation: File should contain 400 lines or less: currently contains 649 (file_length)

Check notice on line 506 in Decimus/Subscriptions/VideoHandler.swift

See this annotation in the file changed.

@xcode-cloud xcode-cloud / Decimus | PR | Build - tvOS

Decimus/Subscriptions/VideoHandler.swift#L506 

File Length Violation: File should contain 400 lines or less: currently contains 506 (file_length)

Check notice on line 56 in Decimus/Subscriptions/VideoSubscription.swift

See this annotation in the file changed.

@xcode-cloud xcode-cloud / Decimus | PR | Build - tvOS

Decimus/Subscriptions/VideoSubscription.swift#L56 

Function Body Length Violation: Function body should span 50 lines or less excluding comments and whitespace: currently spans 68 lines (function_body_length)

Check notice on line 562 in Decimus/Subscriptions/VideoSubscription.swift

See this annotation in the file changed.

@xcode-cloud xcode-cloud / Decimus | PR | Build - tvOS

Decimus/Subscriptions/VideoSubscription.swift#L562 

Function Body Length Violation: Function body should span 50 lines or less excluding comments and whitespace: currently spans 74 lines (function_body_length)

Check notice on line 465 in Decimus/Subscriptions/VideoSubscription.swift

See this annotation in the file changed.

@xcode-cloud xcode-cloud / Decimus | PR | Build - tvOS

Decimus/Subscriptions/VideoSubscription.swift#L465 

Line Length Violation: Line should be 120 characters or less; currently it has 160 characters (line_length)

Check notice on line 42 in Decimus/VideoJitterBuffer.swift

See this annotation in the file changed.

@xcode-cloud xcode-cloud / Decimus | PR | Build - tvOS

Decimus/VideoJitterBuffer.swift#L42 

Function Body Length Violation: Function body should span 50 lines or less excluding comments and whitespace: currently spans 56 lines (function_body_length)

Check notice on line 75 in Decimus/Views/Settings/SubscriptionSettingsView.swift

See this annotation in the file changed.

@xcode-cloud xcode-cloud / Decimus | PR | Build - tvOS

Decimus/Views/Settings/SubscriptionSettingsView.swift#L75 

'onChange(of:perform:)' was deprecated in tvOS 17.0: Use `onChange` with a two or zero parameter action closure instead.

Check notice on line 126 in Decimus/Subscriptions/VideoSubscription.swift

See this annotation in the file changed.

@xcode-cloud xcode-cloud / Decimus | PR | Build - tvOS

Decimus/Subscriptions/VideoSubscription.swift#L126 

Line Length Violation: Line should be 120 characters or less; currently it has 126 characters (line_length)

Check notice on line 419 in Decimus/Subscriptions/VideoSubscription.swift

See this annotation in the file changed.

@xcode-cloud xcode-cloud / Decimus | PR | Build - tvOS

Decimus/Subscriptions/VideoSubscription.swift#L419 

Line Length Violation: Line should be 120 characters or less; currently it has 128 characters (line_length)

Check notice on line 459 in Decimus/Subscriptions/VideoHandler.swift

See this annotation in the file changed.

@xcode-cloud xcode-cloud / Decimus | PR | Build - tvOS

Decimus/Subscriptions/VideoHandler.swift#L459 

Line Length Violation: Line should be 120 characters or less; currently it has 152 characters (line_length)

Check notice on line 5 in Decimus/Subscriptions/VideoHandler.swift

See this annotation in the file changed.

@xcode-cloud xcode-cloud / Decimus | PR | Build - tvOS

Decimus/Subscriptions/VideoHandler.swift#L5 

Blanket Disable Command Violation: Use 'next', 'this' or 'previous' instead to disable the 'type_body_length' rule once, or re-enable it as soon as possible` (blanket_disable_command)
View more details on Xcode Cloud