Add Shared Memory for incoming data. #350
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimEvens
reviewed
Jan 8, 2025
There was a problem hiding this comment.
This is great. Although, we will likely not have more than one slice. It's nice to have this though, because we have that crazy situation that QUIC/MoQ causes where we may not have enough data to parse the needed track alias out to find the subscribe handler.
This is great as the shared memory, but we need something very similar for PayloadData that the subscribe handler will use. In other words, subscribe handler will need to Push() shared pointers as slices. PayloadData also needs to have a method to set the begin iterator and end iterator, which happens after construct.
GhostofCookie
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.