Allow unwrap and pollUnwrap to take in custom descriptions #1162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also allow pollUnwrap to take in custom timeout and polling intervals. Fixes a bug in the async version of withAssertionRecorder where we didn't reset the assertion recorder after tests
noamfreeman
pushed a commit
to noamfreeman/Nimble
that referenced
this pull request
Oct 14, 2024
Also allow pollUnwrap to take in custom timeout and polling intervals. Fixes a bug in the async version of withAssertionRecorder where we didn't reset the assertion recorder after tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1160
This also allows pollUnwrap to take in custom timeout and polling intervals.
Also fixes a bug in the async version of withAssertionRecorder where we didn't reset the assertion recorder after tests.
The PR should summarize what was changed and why. Here are some questions to
help you if you're not sure:
Checklist - While not every PR needs it, new features should consider this list: