Skip to content

Conversation

QuentinWach
Copy link
Owner

Implementing topology optimization via the adjoint method is simple in principle but the current API which is split into two distinct stages makes it somewhat awkward. For example, we would have to re-rasterize the domain after every time that we modify the design. So at the very least, we should likely need to modify the FDTD module so it can directly use a RegularGrid as input rather than just a parametric Design object which it then rasterized internally.

@QuentinWach QuentinWach self-assigned this Sep 29, 2025
@QuentinWach QuentinWach added the enhancement New feature or request label Sep 29, 2025
Copy link

coderabbitai bot commented Sep 29, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch new_topo

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🧪 Early access (Sonnet 4.5): enabled

We are currently testing the Sonnet 4.5 model, which is expected to improve code review quality. However, this model may lead to increased noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience.

Note:

  • Public repositories are always opted into early access features.
  • You can enable or disable early access features from the CodeRabbit UI or by updating the CodeRabbit configuration file.

Comment @coderabbitai help to get the list of available commands and usage tips.

@QuentinWach QuentinWach changed the title Architecture Extension for Adding (Topology) Optimization Architecture Extensions for Adding (Topology) Optimization Sep 29, 2025
@QuentinWach QuentinWach merged commit 55b81f6 into main Oct 7, 2025
23 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant