-
Notifications
You must be signed in to change notification settings - Fork 2
Architecture Extensions for Adding (Topology) Optimization #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…on. It's clear now that I really need to think deeply about the architectural changes needed to implement this rigorously as an API that works as smoothly as the rest.
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🧪 Early access (Sonnet 4.5): enabledWe are currently testing the Sonnet 4.5 model, which is expected to improve code review quality. However, this model may lead to increased noise levels in the review comments. Please disable the early access features if the noise level causes any inconvenience. Note:
Comment |
Implementing topology optimization via the adjoint method is simple in principle but the current API which is split into two distinct stages makes it somewhat awkward. For example, we would have to re-rasterize the domain after every time that we modify the design. So at the very least, we should likely need to modify the FDTD module so it can directly use a RegularGrid as input rather than just a parametric Design object which it then rasterized internally.