Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port to 1.8.9 (legacyfabric) #7

Open
wants to merge 4 commits into
base: 1.19
Choose a base branch
from

Conversation

moehreag
Copy link

@moehreag moehreag commented Oct 5, 2022

somehow there are still people using this version, so they might as well get some of the queer.

Explanation of the new dependencies:

  • fastutil needed to be added since Minecraft didn't already use back then.
  • search-in-resources provides a resourceManager.findResources(...) like syntax for this version, which also didn't exist on 1.8.9.
  • runtime dependency on log4j, otherwise logging breaks for this version of Minecraft in the dev env.

Other changes:

  • replacement of var keywords, because Java 8 doesn't know them (yet)
  • create a small method for Identifier parsing, since that didn't exist in MC's code.

If you consider merging this, maybe create a new branch to point it to in advance.

I'm sorry...
But this lib is too good to not make my mod more gay.
- the comment about FAPI..
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant