Enforce correct scalartype in transfermatrix diagonalisation - #203
Open
VictorVanthilt wants to merge 1 commit into
Open
Enforce correct scalartype in transfermatrix diagonalisation#203VictorVanthilt wants to merge 1 commit into
VictorVanthilt wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 10 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The starting guess for the diagonalisation of transfermatrices did not use the scalartype information of the transfermatrix, leading to methoderrors when calling
CFTDataon schemes with complex tensors.Thanks @dartsushi for pointing this out.