Reverse rules for Enzyme #86
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
... and 22 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
Your PR no longer requires formatting changes. Thank you for your contribution! |
kshyatt
force-pushed
the
ksh/enzyme
branch
2 times, most recently
from
4408849 to
ec8354b
Compare
kshyatt
commented
Oct 27, 2025
| func::Const{typeof($f)}, | ||
| ::Type{RT}, | ||
| A::Annotation{<:AbstractMatrix}, | ||
| arg::Annotation{<:Tuple{<:AbstractMatrix, <:AbstractMatrix}}, |
Member
Author
There was a problem hiding this comment.
Remove AbstractMatrix restrictions here and elsewhere
kshyatt
commented
Oct 27, 2025
| ) where {RT} | ||
| cache_arg = nothing | ||
| # form cache if needed | ||
| cache_A = (EnzymeRules.overwritten(config)[2] && !(typeof(arg) <: Const)) ? copy(A.val) : nothing |
Member
Author
There was a problem hiding this comment.
Is this safe for the ! methods? Those should be tested directly
kshyatt
force-pushed
the
ksh/enzyme
branch
3 times, most recently
from
6b6c44b to
7478c90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.