-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: syntax for strings python>=3.12 #439
base: main
Are you sure you want to change the base?
Conversation
Many thanks @mmcky. I will scan through the lectures. |
Hi Matt, I just pushed some other I think for this warning we need to look for any string that has a |
@@ -1179,26 +1179,26 @@ fig, axs = plt.subplots(3, 3, figsize=(14, 10)) | |||
# quantities | |||
for i, name in enumerate(['K', 'Y', 'Cy', 'Co']): | |||
ax = axs[i//3, i%3] | |||
ax.plot(range(T+1), quant_seq3[:T+1, i], label=name+', $\delta$s=0') | |||
ax.plot(range(T+1), quant_seq4[:T+1, i], label=name+', $\delta$s=0.005') | |||
ax.plot(range(T+1), quant_seq3[:T+1, i], label=rf'{name}, $\delta$s=0') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @HumphreyYang good catch.
thanks @HumphreyYang I hadn't searched for the embedded case. Nice catch. |
Thanks @mmcky and @HumphreyYang for the fixes. Once you get this working please roll out to the other lecture series. |
@HumphreyYang once a |
@HumphreyYang on my local I am getting Syntax Warnings for docstrings. Is this happening to you? For example from
in a docstring is causing issues with It doesn't see to be an issue on the gh build. |
Thanks @mmcky, I did not get this error message. This is interesting, perhaps we need to escape things in the docstring? |
thanks for letting me know @HumphreyYang. It's an odd error. It shouldn't be causing issues as docstrings should be able to contain latex markup. I'll have to do some further digging to see if I can replicate this in another environment. |
This PR fixes a syntax warning across the lecture series
@HumphreyYang if you have time would you mind review this PR to make sure an
r
shouldn't be anrf
for example. It would be nice to have a double check of it.