-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Simplify pages and migrate to gh-pages based deployments #6
Conversation
✅ Deploy Preview for resonant-pie-f0089d ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@mmcky The codebase now looks like a static site - no Jekyll or Liquid components. Have you got a link I can do a super quick review with? Check the site ticks all the boxes and gets the proper google ranking/social score? |
@HumphreyYang if you had time -- would you be able to click on the netlify deployment of this PR and click around to see if you can find any issues. It is looking pretty good to me. The only thing that won't work is the "Download -> BOOK" link as that file is not yet on the ![]() |
Many thanks @mmcky, The page looks great to me. You might have noticed this, but the view source button is not working currently: On the live site (i.e. https://quantecon.github.io/book-dp1-public-companion/intro.html), the button is linked to a branch in the fork by I found two minor issues related to the codebook, and I have created an issue on them in the companion repo. |
thanks @HumphreyYang and @DrDrij for your reviews. |
@jstac I have updated the site based on our discussion today so we can skip the https://65c985ef37cc5587fd320af8--resonant-pie-f0089d.netlify.app/ This is the demo site of what I have put together. I will liaise with @DrDrij about a better icon for the code icon (that replaces the |
@DrDrij we are moving away from a Can you recommend a more suitable icon to describes "code"? ![]() |
Thanks @mmcky . It will be great to see this done. I'm getting a 404 on the GH links. Also, this page says "Slides" https://65c985ef37cc5587fd320af8--resonant-pie-f0089d.netlify.app/code |
Thanks @jstac you will get Thanks for the "slides" catch -- I'll update that now. |
@jstac I will merge this now --- and do a quality check of the preview with all links that will resolve. Then we can trigger a live update once we are happy. |
This PR:
code-book
gh-pages
from jekyll togh actions
based deployments togh-pages
The following were included in the commit history but are now removed.
book-dp1-public-companion
into this repo (which was responsible for building thecode-book
code-book
to the root levelwebsite
is fully static htmlcode-book
as a built asset of thewebsite/code-book
book-dp1-public-companion