-
-
Notifications
You must be signed in to change notification settings - Fork 305
DOC: Update docstrings in lqnash.jl to follow style guide #345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: sudayuga <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot Capitalize the variables b_1, ..., m_i in the equations accordingly:
Lines 19 to 23 in 441d042
| ```math | |
| \sum_{t=1}^{\infty}(x_t' r_i x_t + 2 x_t' w_i | |
| u_{it} +u_{it}' q_i u_{it} + u_{jt}' s_i u_{jt} + 2 u_{jt}' | |
| m_i u_{it}) | |
| ``` |
Lines 27 to 29 in 441d042
| ```math | |
| x_{t+1} = A x_t + b_1 u_{1t} + b_2 u_{2t} | |
| ``` |
- Also add a missing
\beta^{t-1}in the first equation just after\sum_{t=1}^{\infty}.
src/lqnash.jl
Outdated
| =# | ||
|
|
||
| @doc doc""" | ||
| nnash(a, b1, b2, r1, r2, q1, q2, s1, s2, w1, w2, m1, m2; beta=1.0, tol=1e-8, max_iter=1000) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot
Capitalize the variable names a, ..., m2, consistent with those in the descriptions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Capitalized all variable names in the function signature to match the argument descriptions in commit 88b3dd6.
Co-authored-by: oyamad <[email protected]>
Capitalized the variables in the equations (R_i, W_i, Q_i, S_i, M_i, B_1, B_2) and added the missing β^{t-1} discount term in commit 88b3dd6. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
This PR updates the docstring for the
nnashfunction insrc/lqnash.jlto follow the conventions specified in.github/copilot-instructions.md.Changes Made
Added function signature - The docstring now starts with a four-space indented function signature showing the function name and all parameters with their default values:
Updated section headers - Changed from
#####to single#for "Arguments" and "Returns" sections to match the standard style used throughout the codebaseImproved consistency - All parameter and return value descriptions now end with periods for consistency
Fixed typos - Corrected spelling errors:
Capitalized variable names - All variable names in the function signature and mathematical equations now use uppercase to match the argument descriptions:
A,B1,B2,R1,R2,Q1,Q2,S1,S2,W1,W2,M1,M2R_i,W_i,Q_i,S_i,M_i,B_1,B_2Added missing discount term - Added the missing
\beta^{t-1}discount factor in the minimization equationPreserved mathematical notation - Maintained the
@doc doc"""syntax for proper LaTeX rendering in the documentationThe updated docstring provides clearer documentation and follows the established conventions used in other files like
compute_fp.jlandarma.jl.Verification
Original prompt
<issue_description>Follow the instruction in .github/copilot-instructions.md.
Scope: Only edit docstrings in lqnash.jl</issue_description>
Comments on the Issue (you are @copilot in this section)
Fixes #344
Original prompt
Fixes #344
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.