Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change section order of ColumnArticle at md breakpoint #455

Merged
merged 1 commit into from
Sep 16, 2022
Merged

Change section order of ColumnArticle at md breakpoint #455

merged 1 commit into from
Sep 16, 2022

Conversation

gabalafou
Copy link
Contributor

Short-term fix for #452.

@vercel
Copy link

vercel bot commented Sep 14, 2022 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
consulting ✅ Ready (Inspect) Visit Preview Sep 14, 2022 at 10:52PM (UTC)
labs ✅ Ready (Inspect) Visit Preview Sep 14, 2022 at 10:52PM (UTC)

@gabalafou
Copy link
Contributor Author

Testing

We need to examine all of the places that the Column Article block is being used on the websites.

It's a shared component so it could be used on both Consulting and Labs. I'm not sure where or if it's being used on the Consulting site.

@noatamir
Copy link
Contributor

LGTM for Labs. Thanks for the quick fix! 🌟

bskinn
bskinn approved these changes Sep 15, 2022
View reviewed changes
Copy link
Contributor

@bskinn bskinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked, and currently ColumnArticie is not used anywhere I could find on consulting.

All OK from a LLC interaction standpoint.

I did not review from a code correctness standpoint.

trallard
trallard approved these changes Sep 16, 2022
View reviewed changes
Copy link
Member

@trallard trallard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - so approving

@gabalafou gabalafou merged commit 53e56be into develop Sep 16, 2022
@gabalafou gabalafou deleted the tweak-col-article branch September 16, 2022 14:58
@bskinn bskinn mentioned this pull request Sep 22, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trallard trallard trallard approved these changes

@bskinn bskinn bskinn approved these changes

@noatamir noatamir Awaiting requested review from noatamir

Assignees
No one assigned
Labels
area: react status: merge ready ✨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gabalafou @noatamir @bskinn @trallard