Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Compiling CPython and foundational packages with thread sanitizer (TSAN) part #123

Merged
merged 8 commits into from
Dec 24, 2024
Merged

Added Compiling CPython and foundational packages with thread sanitizer (TSAN) part #123

merged 8 commits into from
Dec 24, 2024

Conversation

vfdev-5
Copy link
Contributor

@vfdev-5 vfdev-5 commented Dec 19, 2024

No description provided.

ivoflipse
ivoflipse reviewed Dec 20, 2024
View reviewed changes
docs/debugging.md Outdated Show resolved Hide resolved
rgommers
rgommers reviewed Dec 20, 2024
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for writing this @vfdev-5! It seems to be finding a lot of bugs this week, so certainly a valuable addition to these docs.

docs/debugging.md Outdated Show resolved Hide resolved
docs/debugging.md Outdated Show resolved Hide resolved
docs/debugging.md Outdated Show resolved Hide resolved
docs/debugging.md Show resolved Hide resolved
docs/debugging.md Outdated Show resolved Hide resolved
docs/debugging.md Outdated Show resolved Hide resolved
hawkinsp
hawkinsp reviewed Dec 21, 2024
View reviewed changes
docs/debugging.md Outdated Show resolved Hide resolved
@vfdev-5 vfdev-5 marked this pull request as ready for review December 23, 2024 14:54
@vfdev-5 vfdev-5 requested a review from rgommers December 23, 2024 15:07
@rgommers rgommers added the documentation Improvements or additions to documentation label Dec 24, 2024
rgommers
rgommers approved these changes Dec 24, 2024
View reviewed changes
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, in it goes. Thanks Victor & reviewers!

@rgommers rgommers merged commit 2f6a95a into Quansight-Labs:main Dec 24, 2024
2 checks passed
@vfdev-5 vfdev-5 deleted the howto-compile-with-tsan branch December 24, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivoflipse ivoflipse ivoflipse left review comments

@hawkinsp hawkinsp hawkinsp left review comments

@rgommers rgommers rgommers approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vfdev-5 @rgommers @hawkinsp @ivoflipse