Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rust to porting guide and update tracking guide #115

Merged
merged 10 commits into from
Nov 19, 2024

Conversation

ngoldbaum
Copy link
Collaborator

No description provided.

@rgommers rgommers added the documentation Improvements or additions to documentation label Nov 19, 2024
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @ngoldbaum! A few comments

docs/tracking.md Outdated Show resolved Hide resolved
docs/porting.md Outdated Show resolved Hide resolved
docs/porting.md Outdated Show resolved Hide resolved
docs/porting.md Outdated Show resolved Hide resolved
Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM now, nice doc extensions! It does have a merge conflict that needs resolving though - go ahead and merge once that is done I'd say.

@ngoldbaum ngoldbaum merged commit 329a394 into Quansight-Labs:main Nov 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants