Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Windows installation script #112

Merged
merged 1 commit into from
Nov 8, 2024
Merged

Fix Windows installation script #112

merged 1 commit into from
Nov 8, 2024

Conversation

shinyano
Copy link
Contributor

@shinyano shinyano commented Nov 8, 2024

PR for #111

lysnikolaou
lysnikolaou approved these changes Nov 8, 2024
View reviewed changes
Copy link
Member

@lysnikolaou lysnikolaou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @shinyano!

@lysnikolaou lysnikolaou merged commit 89bb201 into Quansight-Labs:main Nov 8, 2024
2 checks passed
@lysnikolaou lysnikolaou changed the title Improve installation document Fix Windows installation script Nov 8, 2024
@lysnikolaou lysnikolaou mentioned this pull request Nov 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lysnikolaou lysnikolaou lysnikolaou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shinyano @lysnikolaou