Pr/21 commit2 #26
Pr/21 commit2 #26
Conversation
…b file in dev project outputs
…cout & std::cerr where users can consume messages
# Conflicts: # .gitignore
# Conflicts: # src/modules/encoder_angle_calibration.cpp
will revert this before moving onto device config integration
|
@dlazenby - I basically added some simple logging capability which defaults to cout and cerr. For your purposes, you'd call |
|
Unfortunately it's a bad time for me, I'm out on field assignment the next two weeks so I have limited time to review. I looked over these changes and it seems reasonable to me. A lot more thorough than what I had done. I didn't want to add another dependency to quanergy's driver code, but spdlog is a good open source library that implements a sink model. This reminds me of that library. I will say that I had trouble with running multiple drivers (client connections) simultaneously using the logging code that I had written. It would cause intermittent thread conflicts. Please test running 2 or more client connections to multiple sensors from a single application to make sure that logging stream is threadsafe. It is normal for us to have 5+ sensors all connected to the same application. |
|
I may actually go back to the signal/slot idea do to flexibility. I started to use this in the ros node and it is kind of a pain to have it use ostream... |
Reworked the console output to have basic logging functionality which can be redirected to any ostream.