Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop 32 bit support #590

Merged
merged 1 commit into from
Aug 21, 2023
Merged

Drop 32 bit support #590

merged 1 commit into from
Aug 21, 2023

Conversation

johnzl-777
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

Merging #590 (ac5217a) into master (efb7179) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #590      +/-   ##
==========================================
- Coverage   69.48%   69.43%   -0.06%     
==========================================
  Files          78       78              
  Lines        3448     3448              
==========================================
- Hits         2396     2394       -2     
- Misses       1052     1054       +2     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Roger-luo
Copy link
Member

Have you checked if 32-bit actually fails or it's still not fixed upstream?

@Roger-luo
Copy link
Member

Roger-luo commented Aug 21, 2023

Ok I'm convinced, let's drop them for now, optionally with an issue keep investigating what happened to x86. See #598

@Roger-luo Roger-luo merged commit 8f54a03 into master Aug 21, 2023
@Roger-luo Roger-luo deleted the john/drop-32-bit-support-ci branch August 21, 2023 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants