Fix digit escaping in OpenQASM 3 identifier #15305
Open
+37
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous regex used `\w` as the match for an initial id character, and `[\w\d]` for continuations. Actually, `\w` matches any character that `str.isalnum` returns `True` plus the underscore, which includes all Unicode characters in the "digit" class, so is a superset of `\d`. The match `\d` is only the Unicode group `[Nd]` (decimal digits), which is not as complete as the entire `[N?]` set, so we can't even use variants of `[^\W\d_]` or the like to get something usable; we'd have to pull in the third-party `regex` package or the like to make an exact match. This instead causes the Qiskit exporter to allow only a subset of valid OQ3 identifiers on export in lieu of _complete_ matching. Additionally, we now do not accidentally include digits in the allowed set of initial characters for IDs (but do allow then in continuations).
jakelishman
added
stable backport potential
Collaborator
|
One or more of the following people are relevant to this code:
|
Pull Request Test Coverage Report for Build 19320339788Details
💛 - Coveralls |
|
Would it be worth adding a test case for consecutive invalid characters? For example, if a register is named Just wanted to check if this edge case is worth covering, or if you think the existing tests are sufficient? |
Member
Author
|
Thanks Debasmita, that's a good idea. Done in 9745eab. |
jakelishman
commented
Nov 12, 2025
jakelishman
commented
Nov 12, 2025
jakelishman
force-pushed
the
qasm3/fix-identifiers
branch
from
46af300 to
240bf12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous regex used
\was the match for an initial id character, and[\w\d]for continuations. Actually,\wmatches any character thatstr.isalnumreturnsTrueplus the underscore, which includes all Unicode characters in the "digit" class, so is a superset of\d. The match\dis only the Unicode group[Nd](decimal digits), which is not as complete as the entire[N?]set, so we can't even use variants of[^\W\d_]or the like to get something usable; we'd have to pull in the third-partyregexpackage or the like to make an exact match.This instead causes the Qiskit exporter to allow only a subset of valid OQ3 identifiers on export in lieu of complete matching. Additionally, we now do not accidentally include digits in the allowed set of initial characters for IDs (but do allow then in continuations).
Summary
Details and comments
Fix #15303
Fix #15304