Fix/4647 remove anea mc yahoo price#4659
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
Thanks for contributing to Qiskit documentation! Before your PR can be merged, it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient. Thanks! 🙌 One or more of the following people are relevant to this code: |
| "execution_count": null, | ||
| "id": "49cddc2b-6759-4d18-aa1c-c38c344139d7", | ||
| "metadata": {}, | ||
| "outputs": [], |
There was a problem hiding this comment.
Line #11. "AENA.MC",
Do we need to remove this asset? I thought the reason was this stock has been removed from the market
Reply via ReviewNB
| "execution_count": null, | ||
| "id": "49cddc2b-6759-4d18-aa1c-c38c344139d7", | ||
| "metadata": {}, | ||
| "outputs": [], |
There was a problem hiding this comment.
Line #2. assets=assets.to_dict(), # Insert assets as a dictionary
Was the original code by passing dataframe not working? I think passing dictionary is better, but I am just wondering whether it was not working originally.
Reply via ReviewNB
|
@manuelmartin3 Thanks for the fix. I left some comments. The linting check failed. Can you please also install tox and run the following command to reformat the file: |
|
Can you also add "Fixes #4647" in the description of the PR so that the issue will be automatically closed when the PR is merged? Thank you |
I added. |
5 participants
Fixes #4647