Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Update docker tests to future postgres postgis versions #200

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

ponceta
Copy link
Member

@ponceta ponceta commented Feb 23, 2023

Update docker tests to actual postgres postgis versions

Use ubuntu LTS check old postgres postgis, soon to be old, recent and newest

Update docker tests to actual postgres postgis versions
@ponceta ponceta self-assigned this Feb 23, 2023
Adjust docker image tags
@ponceta ponceta closed this Feb 24, 2023
@ponceta ponceta reopened this Feb 24, 2023
@olivierdalang
Copy link
Contributor

Which release does this PR target ? We have no defined policy for 1.x.x, but in the future, dropping support for postgres versions changes would have to be frozen for the next yearly release, so IMO we should already apply this policy and freeze that for 2023.0.

@ponceta
Copy link
Member Author

ponceta commented Feb 24, 2023

@olivierdalang I was only checking automated tests and CI options but the goal is to change that for the 2023.0 Release once the 1.6.0 step is finished. Release policy is in what we discussed a part of 2023 release.

https://github.com/orgs/teksi/projects/2/views/4?pane=issue&itemId=21154279

Remove postgis 2.5 since it isn't supported by the CI already
Test actions/checkout@v3
Upgade Dockerfile to LTR
@ponceta
Copy link
Member Author

ponceta commented Feb 24, 2023

Fix warnings on deprecated libraries and actions :

image

@ponceta ponceta changed the title Update docker tests to actual postgres postgis versions [WIP] Update docker tests to actual postgres postgis versions Feb 24, 2023
@ponceta ponceta added the sustainability Provides a sustainability or maintenance improvement label Feb 28, 2023
@olivierdalang olivierdalang added this to the 2023.0 milestone Mar 9, 2023
@ponceta ponceta changed the title [WIP] Update docker tests to actual postgres postgis versions [WIP] Update docker tests to future postgres postgis versions Jul 17, 2023
@ponceta ponceta closed this Mar 13, 2024
@ponceta ponceta reopened this Mar 13, 2024
@ponceta
Copy link
Member Author

ponceta commented Mar 13, 2024

@3nids it looks like 3.2 and 3.4 have been fixed but not 3.3, any hint / good practices on how to prevent users from using it?

@3nids
Copy link
Member

3nids commented Mar 13, 2024

good question, the simplest is probably in the SQL install script to detect SELECT PostGIS_full_version() and raise an error.

@sjib
Copy link
Contributor

sjib commented Jun 17, 2024

@ponceta Is this still wanted? If yes can you make it 1.6.2 ready

@ponceta
Copy link
Member Author

ponceta commented Aug 22, 2024

Postgis 3.3 docker image has not been updated so it is not fixed, postgis 3.2 is available on postgres 14-3.2 but is already two years old.

@ponceta
Copy link
Member Author

ponceta commented Aug 22, 2024

system_user now looks like a reserved keyword, we have to adapt it to support postgres 16.

@ponceta
Copy link
Member Author

ponceta commented Aug 22, 2024

@sjib here is the full error log if required for postgres 16

psql:/src/03_qgep_db_dss.sql:175: ERROR:  syntax error at or near "system_user"
LINE 1: ALTER TABLE qgep_od.mutation ADD COLUMN system_user  varchar...

@ponceta ponceta closed this Aug 29, 2024
@ponceta ponceta reopened this Aug 29, 2024
@sjib
Copy link
Contributor

sjib commented Aug 29, 2024

#238 should help to solve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sustainability Provides a sustainability or maintenance improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants