Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(resolves #83) Probability in tools needs parameter type #87

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

(resolves #83) Probability in tools needs parameter type #87

wants to merge 4 commits into from
+17 −11

Commits on Sep 20, 2024

  1. (resolves #93) Probability in tools needs parameter type 

    Problem:
- Probability function needs Union[quantum_circuit, ndarray] type for quantum_state
- quantum_state rename from quantumstate

Issues:
- Importing quantum_circuit causes circular dependency
- quantum_circuit import base_core imports from tools qubit
- measure which is in tools imports probability which imports quantum_circuit

Solution:
- 1. Rename qunatumstate to quantum_state
- 2. Add Union type from typing
- 3. Remove qubit from tools and put into separate folder to separate imports
this solve the dependency issue.
    @fabie37
    fabie37 committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    9573bed View commit details
    Browse the repository at this point in the history

  2. (resolves QCpython#83) Probability in tools needs parameter type 

    Problem:
- Probability function needs Union[quantum_circuit, ndarray] type for quantum_state
- quantum_state rename from quantumstate

Issues:
- Importing quantum_circuit causes circular dependency
- quantum_circuit import base_core imports from tools qubit
- measure which is in tools imports probability which imports quantum_circuit

Solution:
- 1. Rename qunatumstate to quantum_state
- 2. Add Union type from typing
- 3. Remove qubit from tools and put into separate folder to separate imports
this solve the dependency issue.
    @fabie37
    fabie37 committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    cf0ee56 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'refactor/issue-83' of https://github.com/fabie37/qcpy i… 

    …nto refactor/issue-83
    @fabie37
    fabie37 committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    fd8fa14 View commit details
    Browse the repository at this point in the history

  4. (resolves QCpython#83) Add qubit to src imports and run black formatter 

    Problem
- Project runs black formatter
- qubit needs to be included in root import

Solution
- run `black qcpy/`
- add `from ./qubit import *`
    @fabie37
    fabie37 committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    e0449de View commit details
    Browse the repository at this point in the history