(resolves #83) Probability in tools needs parameter type #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: - Probability function needs Union[quantum_circuit, ndarray] type for quantum_state - quantum_state rename from quantumstate Issues: - Importing quantum_circuit causes circular dependency - quantum_circuit import base_core imports from tools qubit - measure which is in tools imports probability which imports quantum_circuit Solution: - 1. Rename qunatumstate to quantum_state - 2. Add Union type from typing - 3. Remove qubit from tools and put into separate folder to separate imports this solve the dependency issue.
Problem: - Probability function needs Union[quantum_circuit, ndarray] type for quantum_state - quantum_state rename from quantumstate Issues: - Importing quantum_circuit causes circular dependency - quantum_circuit import base_core imports from tools qubit - measure which is in tools imports probability which imports quantum_circuit Solution: - 1. Rename qunatumstate to quantum_state - 2. Add Union type from typing - 3. Remove qubit from tools and put into separate folder to separate imports this solve the dependency issue.
…nto refactor/issue-83
Problem - Project runs black formatter - qubit needs to be included in root import Solution - run `black qcpy/` - add `from ./qubit import *`
|
Hi @fabie37, thank you for checking these issues out! Looks great so far, would it possible to change the imports with an asterisk to an explicit import? This has been needed to be done and would be a big help thank you! |
Works with me! Regardless, looks great. |
|
Awesome, glad I could help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Requesting to pull changes to resolve issue #83
Description
Fixes issue presented in #83
Please include a summary of the changes and the motivation behind them. If applicable, link to any related issues.
Type of Change
Please check the type of change your PR introduces:
Checklist
blackformatter on the codebase. (CI/CD will fail if neglected)Related Issues
Screenshots (if applicable)
NA
Additional Notes
Problem:
Issues:
Solution: