Code cleanup and modernize build (#9)

* Build with Tycho 1.7.0 * Build against Eclipse simrel 2020-06 * Remove redundant modifiers. * Remove redundant array creation for varargs method.
PyvesB · Aug 5, 2020 · 5c012af · 5c012af
1 parent b0e2baf
commit 5c012af
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 8 deletions.
diff --git a/...gin/src/main/java/io/github/pyvesb/eclipse_solargraph/launch/IResourceLaunchShortcut.java b/...gin/src/main/java/io/github/pyvesb/eclipse_solargraph/launch/IResourceLaunchShortcut.java
@@ -24,7 +24,7 @@
 public interface IResourceLaunchShortcut extends ILaunchShortcut {
 
 	@Override
-	public default void launch(ISelection selection, String mode) {
+	default void launch(ISelection selection, String mode) {
 		if (selection instanceof IStructuredSelection) {
 			Object element = ((IStructuredSelection) selection).getFirstElement();
 			IResource resource = null;
@@ -45,10 +45,10 @@ public default void launch(ISelection selection, String mode) {
 	}
 
 	@Override
-	public default void launch(IEditorPart editor, String mode) {
+	default void launch(IEditorPart editor, String mode) {
 		launchResource(editor.getEditorInput().getAdapter(IResource.class), mode);
 	}
 
-	public abstract void launchResource(IResource resource, String mode);
+	void launchResource(IResource resource, String mode);
 
 }
diff --git a/...h-plugin/src/main/java/io/github/pyvesb/eclipse_solargraph/launch/RubyLaunchTabGroup.java b/...h-plugin/src/main/java/io/github/pyvesb/eclipse_solargraph/launch/RubyLaunchTabGroup.java
@@ -15,13 +15,12 @@
 import org.eclipse.debug.ui.AbstractLaunchConfigurationTabGroup;
 import org.eclipse.debug.ui.CommonTab;
 import org.eclipse.debug.ui.ILaunchConfigurationDialog;
-import org.eclipse.debug.ui.ILaunchConfigurationTab;
 
 public class RubyLaunchTabGroup extends AbstractLaunchConfigurationTabGroup {
 
 	@Override
 	public void createTabs(ILaunchConfigurationDialog dialog, String mode) {
-		setTabs(new ILaunchConfigurationTab[] { new RubyLaunchTab(), new CommonTab() });
+		setTabs(new RubyLaunchTab(), new CommonTab());
 
 	}
 

diff --git a/...raph-plugin/src/main/java/io/github/pyvesb/eclipse_solargraph/preferences/Preference.java b/...raph-plugin/src/main/java/io/github/pyvesb/eclipse_solargraph/preferences/Preference.java
@@ -18,7 +18,7 @@
 
 public interface Preference<T> {
 
-	static final IEclipsePreferences PREFERENCES = InstanceScope.INSTANCE
+	IEclipsePreferences PREFERENCES = InstanceScope.INSTANCE
 			.getNode(FrameworkUtil.getBundle(Preference.class).getSymbolicName());
 
 	String getKey();

diff --git a/eclipse-solargraph-target-platform/eclipse-solargraph-target-platform.target b/eclipse-solargraph-target-platform/eclipse-solargraph-target-platform.target
@@ -3,7 +3,7 @@
 <target name="eclipse-solargraph-target-platform">
 	<locations>
 		<location includeAllPlatforms="false" includeConfigurePhase="false" includeMode="planner" includeSource="true" type="InstallableUnit">
-			<repository location="https://download.eclipse.org/releases/2019-12/"/>
+			<repository location="https://download.eclipse.org/releases/2020-06/"/>
 			<unit id="org.eclipse.core.runtime" version="0.0.0"/>
 			<unit id="org.eclipse.debug.ui" version="0.0.0"/>
 			<unit id="org.eclipse.platform.ide" version="0.0.0"/>

diff --git a/pom.xml b/pom.xml
@@ -16,7 +16,7 @@
 	</modules>
 	<properties>
 		<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
-		<tycho.version>1.6.0</tycho.version>
+		<tycho.version>1.7.0</tycho.version>
 	</properties>
 	<build>
 		<plugins>