Modify the PyROS Logging System #3732
Open
+774
−256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #3732 +/- ##
==========================================
+ Coverage 89.31% 89.33% +0.02%
==========================================
Files 896 896
Lines 103697 103774 +77
==========================================
+ Hits 92619 92709 +90
+ Misses 11078 11065 -13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mrmundt
requested changes
Oct 7, 2025
| * **Preprocessing information** (lines 35--37): | ||
| Wall time required for preprocessing | ||
| the deterministic model and associated components, | ||
| i.e., standardizing model components and adding the decision rule |
There was a problem hiding this comment.
Suggested change
| i.e., standardizing model components and adding the decision rule | |
| e.g., standardizing model components and adding the decision rule |
I think you mean e.g. ("such as") here? (It's possible I am reading it incorrectly, though)
Comment on lines
+3303
to
+3304
| # for some fields, we choose floats with more than four | ||
| # four decimal points to ensure rounding also matches |
There was a problem hiding this comment.
Suggested change
| # for some fields, we choose floats with more than four | |
| # four decimal points to ensure rounding also matches | |
| # for some fields, we choose floats with more than four | |
| # decimal points to ensure rounding also matches |
Comment on lines
+3339
to
+3340
| # for some fields, we choose floats with more than four | ||
| # four decimal points to ensure rounding also matches |
There was a problem hiding this comment.
Suggested change
| # for some fields, we choose floats with more than four | |
| # four decimal points to ensure rounding also matches | |
| # for some fields, we choose floats with more than four | |
| # decimal points to ensure rounding also matches |
Comment on lines
+3594
to
+3595
| Test method for logging config user values logs | ||
| nothing if all values are set to default. |
There was a problem hiding this comment.
The grammar here is weird enough that I'm not actually sure what the sentence is supposed to mean.
Comment on lines
+251
to
+253
| # note: first clause of logical expression | ||
| # accounts for bug(?) causing an iterate | ||
| # of user_values to be the config dict itself |
There was a problem hiding this comment.
Is this related to #3721? If so, it might be worthwhile to put that issue number in here so people can go read more about it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary/Motivation:
This PR modifies the PyROS solver output logging system so that the output shown by the default logger (or any other
INFO-level logger) is simplified.Changes proposed in this PR:
DEBUG, rather thanINFOlevel: (i) full PyROS solver config, (ii) backup solver invocations, (iii) subproblem solve failures for the master feasibility and DR polishing problems, (iv) timing profile, (v) component statistics for the preprocessed modelINFO-level) iteration log tableINFOlevelTODO
ConfigDict.user_values()should return only child entries, not instance itself #3722 merged) Simplify logging of user optionsDEBUG-level logsLegal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: