-
Notifications
You must be signed in to change notification settings - Fork 557
Ensure PyROS Supports Problems Containing No Variables/Uncertain Parameters #3720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure PyROS Supports Problems Containing No Variables/Uncertain Parameters #3720
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3720 +/- ##
=======================================
Coverage 89.31% 89.31%
=======================================
Files 896 896
Lines 103682 103684 +2
=======================================
+ Hits 92605 92607 +2
Misses 11077 11077
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty good. One implementation change that would be nice, and maybe a little more information in the warnings?
Co-authored-by: John Siirola <[email protected]>
Summary/Motivation:
As an example from #2555 suggests, PyROS is (now) capable of solving RO models that do not have variables appearing in the model's active objective or constraints. However, PyROS currently raises an exception if the user-supplied arguments
first_stage_variables
andsecond_stage_variables
are (cast to) empty lists.Further, PyROS is also capable of solving problems that have no uncertain parameters (efficiently, as of #3503). However, this is not (fully) checked in the testing modules.
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: