-
Notifications
You must be signed in to change notification settings - Fork 546
Enable parallel big-M calculation for gdp.mbigm transformation #3641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
sadavis1
wants to merge
24
commits into
Pyomo:main
Choose a base branch
from
sadavis1:mbigm-parallel
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+584
−231
Open
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
2e2cb24
fix a bug in bigm_mixin
sadavis1 72003c4
non-working attempt at threaded mbigm
sadavis1 526bca4
Working attempt at parallel mbigm when using baron, but leads to a de…
sadavis1 69b22ce
delete unused code
sadavis1 cf09d52
Improve several edge cases
sadavis1 89218cf
Handle edge cases "better"
sadavis1 cdb0103
Handle ipopt in a somewhat better way
sadavis1 160fc22
apply black
sadavis1 83a2a20
apply black on more files
sadavis1 2e5e07e
Cleanup and formatting
sadavis1 21ea319
black yet again
sadavis1 523bbaa
Merge branch 'main' of github.com:Pyomo/pyomo into mbigm-parallel
sadavis1 c9794a5
Switch from multithreading to multiprocessing
sadavis1 a2d52cf
fix a bug, also reflow my block comments
sadavis1 2ff8888
Merge branch 'main' of github.com:Pyomo/pyomo into mbigm-parallel
sadavis1 738223b
Import plugins manually, also remove unused imports
sadavis1 bb7a816
remove debug code
sadavis1 1c0bb3e
Set 'name' class attribute of LegacySolver objects to the legacy name
sadavis1 d57501d
Consider and fix more edge cases
sadavis1 2de93fb
Test process spawning methods
sadavis1 2c5d3e5
reorder some imports
sadavis1 bcbb9ab
Revert "Set 'name' class attribute of LegacySolver objects to the leg…
sadavis1 edc0f30
Pickle classes instead of passing solver names
sadavis1 9e93f17
Move thread pool setup out of _transform_DisjunctionDatas
sadavis1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You touched this line so now I get to snark. It's good practice, if catching a general exception, to raise the original exception as well so folks can directly inspect it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we already do this? There is a
raise
statement after we log.