Skip to content

Bug fixes in the current parmest.py and example files #3635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

slilonfe5
Copy link

@slilonfe5 slilonfe5 commented Jun 19, 2025

Fixes # .

Summary/Motivation:

There is a raise error bug in the checks for experiment_outputs and unknown_parameters in the current parmest.py file: it fails to raise an error when the pyomo model used in the parmest example files lacks these attributes.

Changes proposed in this PR:

  • Add a raise in the try and except code that checks for experiment_outputs and unknown_parameters in the current parmest.py file
  • Add an experiment_outputs attribute to the pyomo model of the parmest examples that lack this attribute

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@slilonfe5 slilonfe5 marked this pull request as draft June 19, 2025 17:38
@slilonfe5 slilonfe5 marked this pull request as ready for review June 19, 2025 19:55
@slilonfe5
Copy link
Author

@adowling2 @djlaky @mrmundt @jsiirola I fixed the parmest raise error bug that we talked about at the Tuesday Dev meeting. This should be ready for review.

@blnicho blnicho moved this from Todo to Review In Progress in July 2025 Release Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Review In Progress
Development

Successfully merging this pull request may close these issues.

3 participants