Fix seq widgets #123
Open
Fix seq widgets #123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@krysros I started the run, and so far lint failed, but it's not clear to me why. Perhaps you can make sense of it? https://github.com/Pylons/deformdemo/runs/6872633267?check_suite_focus=true We'll see about the other builds. At this point, I am OK with dropping Python 3.6 and adding 3.10, too. |
Author
|
I have no idea about lint fail yet. I passed all functional tests running locally from deform with the changes applied in Pylons/deform#523, Pylons/deform#524, #123 and with the following modifications of https://github.com/Pylons/deform/blob/1a6e9e07a9a7fa0208c1aa219649d99ebc132eb7/run-selenium-tests.bash#L31
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request should fix functional tests of Pylons/deform#518.