-
-
Notifications
You must be signed in to change notification settings - Fork 475
fix(colour): Fix dark_theme color #2768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Do we even need that anymore. There's too many "dark themes" now. Even without nitro. /gen Q for @Pycord-Development/contributors |
Or should I add an individual function for each theme? |
This color is completely irrelevant now anyways with components v2 |
if we were to go ahead with this PR, then we should have the previous dark color in a field called |
i think "dark_theme" should be left as is and deprecated in favour of the official names "dark", "onyx" and "ash" |
I think we should get rid of all these "theme" things. I see no use in it anyways |
The use afaik is for making it blend with the bg |
There are too many backgrounds for it to be reasonable anymore (also no gradients) |
Summary
In this PR I set the color of dark_theme to the new dark_theme color of Discord
Information
examples, ...).
Checklist
type: ignore
comments were used, a comment is also left explaining why.