Skip to content

fix(colour): Fix dark_theme color #2768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

bastigamedc
Copy link

Summary

In this PR I set the color of dark_theme to the new dark_theme color of Discord

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
  • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes. (I don't know where to update this)

@Lulalaby
Copy link
Member

Lulalaby commented Apr 26, 2025

Do we even need that anymore. There's too many "dark themes" now. Even without nitro. /gen Q for @Pycord-Development/contributors

@bastigamedc
Copy link
Author

Or should I add an individual function for each theme?

@plun1331
Copy link
Member

This color is completely irrelevant now anyways with components v2

@JustaSqu1d
Copy link
Member

if we were to go ahead with this PR, then we should have the previous dark color in a field called old_dark_theme or something

@NeloBlivion
Copy link
Member

i think "dark_theme" should be left as is and deprecated in favour of the official names "dark", "onyx" and "ash"

@Lulalaby
Copy link
Member

I think we should get rid of all these "theme" things. I see no use in it anyways

@Paillat-dev
Copy link
Contributor

The use afaik is for making it blend with the bg

@plun1331
Copy link
Member

plun1331 commented May 9, 2025

The use afaik is for making it blend with the bg

There are too many backgrounds for it to be reasonable anymore (also no gradients)
The best solution if you really want this functionality would be to use cv2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants