fix: 🐛 Fix ValueError when using Flag
#2759
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
Signed-off-by: Paillat <[email protected]>
plun1331
reviewed
May 9, 2025
Comment on lines
-122
to
+125
| MissingField = field(default_factory=lambda: MISSING) | ||
|
|
||
|
|
||
| def missing_field_factory() -> field: | ||
| return field(default_factory=lambda: MISSING) |
There was a problem hiding this comment.
maybe I'm stupid but how is this different
There was a problem hiding this comment.
Because the other one was referencing the same object every time, whereas here it creates a new object. I have no knowledge of the python interpreter internals that make this work, but yeah
VincentRPS
approved these changes
May 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
See also my comment on #2443 .
The issue was that a
dataclasses.fieldobject could not be reused and caused unhelpfulTypeErrors.This, or something fixing this issue should ideally be merged before #2443 is merged, and then master merged into #2443 .
Information
fixes:
TypeErrorwhen usingFlagwith python 3.11+ #2758examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.