refactor: Rewrite the role tags mess

[Paillat-dev]

Summary

Rewrite the role tags mess.

Information

• This PR fixes an issue.
• This PR adds something new (e.g. new method or parameters).
• This PR is a breaking change (e.g. methods or parameters removed/renamed).
• This PR is not a code change (e.g. documentation, README, typehinting,
  examples, ...).

Checklist

• I have searched the open pull requests for duplicates.
• If code changes were made then they have been tested.
  • I have updated the documentation to reflect the changes.
• If type: ignore comments were used, a comment is also left explaining why.
• I have updated the changelog to include these changes.

[plun1331]

This looks really easy to make backwards compatible, can we just do that and deprecate all the compatibility methods?

[Paillat-dev]

Yeah maybe i'll try, but it sucks when I reused method names to become properties

[Paillat-dev]

What are your thoughts on adding something like an enum, e.g. Role.type to describe the role type ?

[Lulalaby]

As we previously talked on dcs, the role type enum is the best way. Like plun said, deprecated all current methods and just create the type on role. But the docs should clarify that it's calculated since it's not returned by discord

[Paillat-dev]

Here is a handy snippet for testing this:

import logging
import os
from datetime import datetime, UTC
from dotenv import load_dotenv

import discord

load_dotenv()

logging.basicConfig(level=logging.DEBUG)

TOKEN = os.getenv("TOKEN_3")

bot = discord.Bot()


@bot.slash_command()
async def test_roles(ctx: discord.ApplicationContext, role: discord.Role):
    await ctx.defer()
    if not ctx.guild:
        return await ctx.respond("This command must be used in a guild.")
    fetched_role = await ctx.guild.fetch_role(role.id)
    await ctx.respond(f"""```
Role:
    {role!r}
Role tags:
    {role.tags!r}
Role tags data:
    {role.tags._data if role.tags else None}

Fetched role:
    {fetched_role!r}
Fetched role tags:
    {fetched_role.tags!r}
Fetched role tags data:
    {fetched_role.tags._data if fetched_role.tags else None}       
```""")

bot.run(TOKEN)

[Paillat-dev]

Do not merge yet

[Paillat-dev]

Missing testing is only twitch/ytb roles, everything else is tested.

[Paillat-dev]

Wait this could be removed if this pr is merged before 2.7 since it was added after 2.6.1. Same for is_available_for_purchase

[Paillat-dev]

Any news on this topic ?

[Paillat-dev]

@Lulalaby Any news on this btw ?

[Lulalaby]

not yet :(