Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add missing with_counts parameter to fetch_guilds method #2615

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

feat: add missing with_counts parameter to fetch_guilds method #2615

wants to merge 7 commits into from
+27 −4

Conversation

BruhDark
Copy link

@BruhDark BruhDark commented Oct 21, 2024 •
edited
Loading

Summary

This PR adds with_counts for the fetch_guilds method, which was missing.

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@BruhDark BruhDark requested a review from a team as a code owner October 21, 2024 04:54
@BruhDark
Copy link
Author

Side note 1: Blame my IDE for "fixing" spaces in other funcs in the files I edited.
Side note 2: Might wanna double check the edited documentation on such methods, don't know if it is correct.

@plun1331 plun1331 changed the title refactor: add missing with_counts parameter to fetch_guilds method feat: add missing with_counts parameter to fetch_guilds method Oct 21, 2024
plun1331
plun1331 reviewed Oct 21, 2024
View reviewed changes
Copy link
Member

@plun1331 plun1331 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog please :3 (under Added)

@plun1331 plun1331 added priority: low Low Priority status: awaiting review Awaiting review from a maintainer feature Implements a feature API Reflection Discords API wasn't correctly reflected in the lib labels Oct 21, 2024
Dorukyum
Dorukyum requested changes Oct 21, 2024
View reviewed changes
discord/client.py Outdated Show resolved Hide resolved
discord/iterators.py Outdated Show resolved Hide resolved
BruhDark and others added 3 commits October 21, 2024 11:01
@BruhDark @Dorukyum
Update discord/client.py
05d1fc2 
Co-authored-by: Dorukyum <[email protected]>
Signed-off-by: Dark <[email protected]>
@BruhDark @Dorukyum
Update discord/iterators.py
5c791f1 
Co-authored-by: Dorukyum <[email protected]>
Signed-off-by: Dark <[email protected]>
@BruhDark
Update CHANGELOG.md
fc60783
@BruhDark
Copy link
Author

Done

@plun1331 plun1331 enabled auto-merge (squash) October 21, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plun1331 plun1331 plun1331 approved these changes

@ChickenDevs ChickenDevs Awaiting requested review from ChickenDevs

@Dorukyum Dorukyum Awaiting requested review from Dorukyum

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
API Reflection Discords API wasn't correctly reflected in the lib feature Implements a feature PA: All Contributors pending priority: low Low Priority status: awaiting review Awaiting review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BruhDark @plun1331 @Dorukyum