fix: webhooks not sending attachment info #2513
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dorukyum
reviewed
Aug 4, 2024
| @@ -644,8 +644,9 @@ def handle_message_parameters( | |||
| payload["embeds"] = [] if embed is None else [embed.to_dict()] | |||
| if content is not MISSING: | |||
| payload["content"] = str(content) if content is not None else None | |||
| attachments = [] | |||
There was a problem hiding this comment.
This makes the line below obsolete
There was a problem hiding this comment.
then += instead? it needs to be defined outside the if
There was a problem hiding this comment.
I think you intended to create a new variable, but this one overshadows the parameter with the same name.
There was a problem hiding this comment.
Or it needs to be put in an else after the if
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds
attachmentsto the multipart payload sent in webhooks, which previously didn't exist. This only impacteddescription, but necessary to implement nonetheless.I HOPE this doesn't break anything, but further testing with editing attachments would be appreciated.
Information
examples, ...).
Checklist
type: ignorecomments were used, a comment is also left explaining why.