-
-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: app emojis #2501
base: master
Are you sure you want to change the base?
feat: app emojis #2501
Conversation
Removed draft status as this is completely functional, just have to go through and replace instances of |
"guild_id", | ||
"application_id", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, since it came to light that DisnakeDev/disnake#1209 is a blatant copy, I'll share feedback I gave there :)
You should move these two slots to the relevant subclasses, AppEmoji
doesn't need a guild_id
slot and vice versa
@NeloBlivion can u finish this (see comment) |
Summary
Implements discord/discord-api-docs#7010
Very rough draft, considering new emoji classes
Information
examples, ...).
Checklist
type: ignore
comments were used, a comment is also left explaining why.