Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: app emojis #2501

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

NeloBlivion
Copy link
Member

@NeloBlivion NeloBlivion commented Jul 19, 2024

Summary

Implements discord/discord-api-docs#7010
Very rough draft, considering new emoji classes

Information

  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
  • This PR is a breaking change (e.g. methods or parameters removed/renamed).
  • This PR is not a code change (e.g. documentation, README, typehinting,
    examples, ...).

Checklist

  • I have searched the open pull requests for duplicates.
  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • If type: ignore comments were used, a comment is also left explaining why.
  • I have updated the changelog to include these changes.

@Lulalaby Lulalaby assigned Lulalaby and NeloBlivion and unassigned Lulalaby Jul 19, 2024
@Lulalaby Lulalaby self-requested a review July 19, 2024 00:42
@Lulalaby Lulalaby added priority: medium Medium Priority status: in progress Work in Progess feature Implements a feature labels Jul 19, 2024
@Lulalaby Lulalaby added this to the v2.7 milestone Jul 19, 2024
@NeloBlivion
Copy link
Member Author

Removed draft status as this is completely functional, just have to go through and replace instances of Emoji with GuildEmoji (Emoji is still aliased, possibly deprecate for 2.7?)

Comment on lines 60 to +61
"guild_id",
"application_id",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, since it came to light that DisnakeDev/disnake#1209 is a blatant copy, I'll share feedback I gave there :)

You should move these two slots to the relevant subclasses, AppEmoji doesn't need a guild_id slot and vice versa

@Lulalaby
Copy link
Member

@NeloBlivion can u finish this (see comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

5 participants