-
-
Notifications
You must be signed in to change notification settings - Fork 460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ext.pages): Add use_styled_buttons
#1811
Conversation
use_styled_buttons
use_styled_buttons
I like how the ci fails again |
@Lulalaby it doesn’t like me :/ |
No worries. Is fixed. Please address the requested changes. |
Head branch was pushed to by a user without write access
Added changes 👍 |
I don't even question anymore how you've managed to let the ci fail two more times just by applying the string changes |
CI sometimes fails when a new build is triggered while the previous isn't finished |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the other comments, please add a changelog entry for both the new params and new method.
for more information, see https://pre-commit.ci
Co-authored-by: Lala Sabathil <[email protected]>
Co-authored-by: Lala Sabathil <[email protected]>
Co-authored-by: Lala Sabathil <[email protected]>
Head branch was pushed to by a user without write access
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After testing, I found that the style is highly inconsistent on MacOS. I've included examples from both before and after my suggested changes.
Before: System emoji is used for both the first and last buttons. The "next" button appears fine, but the "prev" button is oversized and the bottom of the character is clipped off.
After: There is a blue outline on the emojis, but full parity is achieved between each emoji and between all operating systems as the discord emoji set is used.
Co-authored-by: BobDotCom <[email protected]>
Should I add #1818 into this pr for v2.4? |
Personally I would prefer this |
Please add a changelog entry |
@Nzii3 trash? |
Summary
Adds
use_styled_buttons
inext.pages.Paginator
which essentially styles buttons with emojis by using a single parameter. Overwritesuse_default_buttons
when used in the Paginator__init__
.Information
examples, ...).
Checklist
type: ignore
comments were used, a comment is also left explaining why.