Skip to content
This repository was archived by the owner on Jan 29, 2019. It is now read-only.

Conversation

@lumbric
Copy link
Contributor

@lumbric lumbric commented Nov 3, 2017

I'm not sure if this file should go to the root folder of this repository.

Copy link
Contributor

@alexwlchan alexwlchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think root is probably fine.

@lumbric Because this is a one-off script, I’m less fussed about code quality. I’m happy to do a proper code review if you’d find that useful; otherwise I’ll probably merge as-is. What would you prefer?

@lumbric
Copy link
Contributor Author

lumbric commented Nov 4, 2017

I'd be interested in some feedback!
(The larges flaw, I've noticed so far is that I shouldn't have trusted on "video:" being already part of the session files.)

@alexwlchan
Copy link
Contributor

I'd be interested in some feedback!

Cool, I’ll try to do a review sometime this week.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants