Do not elide lifetimes and try to be disciplined about naming the GIL lifetime 'py. #390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamreichold
force-pushed
the
dont-elide-lifetimes
branch
from
99146f8 to
f98f87a
Compare
mejrs
approved these changes
Sep 8, 2023
| @@ -3,9 +3,9 @@ use numpy::{IntoPyArray, PyArray2, PyReadonlyArray2}; | |||
| use pyo3::{exceptions::PyRuntimeError, pymodule, types::PyModule, PyResult, Python}; | |||
|
|
|||
| #[pymodule] | |||
| fn rust_linalg(_py: Python, m: &PyModule) -> PyResult<()> { | |||
| fn rust_linalg<'py>(_py: Python<'py>, m: &'py PyModule) -> PyResult<()> { | |||
There was a problem hiding this comment.
Can these (and others) be anonymous? i.e. fn rust_linalg(_py: Python<'_>, m: &'_PyModule) -> PyResult<()> {?
There was a problem hiding this comment.
They can, but I decidedly tried to keep the GIL lifetime named 'py instead of keeping it anonymous where that would be possible. I think if we do add these for documentation, we should go all the way.
adamreichold
force-pushed
the
dont-elide-lifetimes
branch
from
f98f87a to
ac8190b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.