add Py_HashBuffer to pyo3-ffi
#5086
Merged
+63
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bschoenmaeckers
force-pushed
the
hashbuffer
branch
from
a774622 to
f3d3160
Compare
davidhewitt
approved these changes
Apr 23, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
davidhewitt
reviewed
Apr 23, 2025
pyo3-ffi/src/pyhash.rs
Outdated
Comment on lines
17
to
19
|
|
||
| #[cfg(Py_3_14)] | ||
| pub fn Py_HashBuffer(ptr: *const c_void, len: Py_ssize_t) -> Py_hash_t; |
There was a problem hiding this comment.
It looks like this should be located in src/cpython/pyhash.rs (that file may need updating); maybe please sync this file with 3.13 locations while you're at it?
There was a problem hiding this comment.
There was a problem hiding this comment.
Whoops, I picked the wrong pyhash file. Will do an update as well!
bschoenmaeckers
force-pushed
the
hashbuffer
branch
3 times, most recently
from
ddc93f9 to
cf03378
Compare
davidhewitt
approved these changes
Apr 25, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
I think the ci does not like adding python 3.14 functions. @davidhewitt should we wait for full 3.14 support? |
davidhewitt
reviewed
Apr 25, 2025
| use std::os::raw::{c_char, c_int, c_void}; | ||
|
|
||
| #[repr(C)] | ||
| #[derive(Copy, Clone)] |
There was a problem hiding this comment.
Suggested change
| #[derive(Copy, Clone)] | |
| #[derive(Copy, Clone)] | |
| #[cfg(not(any(PyPy, GraalPy)))]` |
... and similar for PyHash_GetFuncDef, perhaps.
bschoenmaeckers
force-pushed
the
hashbuffer
branch
from
77b7b31 to
dc4a817
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is maybe too early to add support for python 3.14 function, but this paves the way to remove the private
_Py_HashBytes.ref pythoncapi-compat