replace PyString::from_object with PyString::from_encoded_object
#5017
Conversation
davidhewitt
force-pushed
the
deprecate-string-from-object
branch
3 times, most recently
from
ec502ec to
5de3f93
Compare
|
Looks like adding a deprecation is discouraged in a patch, so will keep this for 0.25. Think we'll start merging all those changes in shortly, I just want to get 0.24.1 done first. |
|
With #5021 prepped, I think this is ready for merge, if others agree this is a good idea? |
| encoding: &CStr, | ||
| errors: &CStr, |
There was a problem hiding this comment.
Should these be Options to "have the interface use the default values" or do we want to explicitly not provide that option?
There was a problem hiding this comment.
Ah good spot. I'll have a think about this, I'm not sure which I prefer 🤔
| } | ||
|
|
||
| /// Deprecated name for [`PyString::from_object`]. | ||
| #[deprecated(since = "0.23.0", note = "renamed to `PyString::from_object`")] | ||
| #[deprecated( |
There was a problem hiding this comment.
Since this was deprecated already, we can probably just remove it already, no?
There was a problem hiding this comment.
Yep, just a race with the other prs, think this function is deleted now 🙌
Followup to #5008, as per my suggestion in #5005