RFC: remove private _Py symbols from pyo3-ffi
#4379
Closed
+286
−422
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3762
This PR removes (as much as possible) all FFI functions and constants which start with
_Py. Given that the guidance in #3762 from the CPython team is that we shouldn't be using these symbols (except in some cases where they are ABI implementation details) I have proceeded to remove them rather than deprecate. In the cases where we need to use them for implementations I removed thepubfrom the symbol definition so thatpyo3-ffiretains use of the symbol without re-exporting.Marked as draft for now as I need to finish off later; if we agree that this is a good idea then I will:
Architecture.md/Contributing.mdto note that we don't expose these symbols.