refactor build so that pgo is part of normal pathway#3257
Draft
davidhewitt wants to merge 4 commits into
Draft
Conversation
davidhewitt
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that PGO can misalign with actual wheel builds. I tried to fix this by removing the dedicated PGO wheel-building functions and instead introducing a
build_single_unithelper which either runs a PGO cycle or does a single build.I also added some additional testing.
AI Disclosure
I used AI to factor this out, in particular the additional test cases for multiple interpreters using uv.