Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1984.
--filter-filesapplies skip rules to explicitly supplied files but ignores supported extensions. Consequently,isort example.py --filter-files --ext txt --checkstill checks the Python file and can exit with an error.Apply the existing
is_supported_filetypecheck to file arguments during filtering. Directories continue through normal discovery, and explicitly supplied files without--filter-filesretain their existing behaviour.Regression tests cover explicit files, directory discovery, check mode, and the unfiltered case. Two new cases fail before the fix.
Validation:
python -m pytest tests/unit/test_main.py tests/unit/test_settings.py -q --tb=short --show-capture=no: 57 passed, 1 skipped.mypy isort/main.pypassed.AI assistance: Codex prepared this fix and regression coverage and ran the checks above. No independent human review is claimed.