Repository navigation
feat: allow local preservation of redundant aliases - #2706
Closed
anshurajbisoyi98-ctrl wants to merge 6 commits into
Closed
anshurajbisoyi98-ctrl wants to merge 6 commits into
anshurajbisoyi98-ctrl wants to merge 6 commits into
Conversation
Signed-off-by: Anshu Raj Bisoyi <anshurajbisoyi98@gmail.com>
Signed-off-by: Anshu Raj Bisoyi <anshurajbisoyi98@gmail.com>
Signed-off-by: Anshu Raj Bisoyi <anshurajbisoyi98@gmail.com>
Signed-off-by: Anshu Raj Bisoyi <anshurajbisoyi98@gmail.com>
Signed-off-by: Anshu Raj Bisoyi <anshurajbisoyi98@gmail.com>
Signed-off-by: Anshu Raj Bisoyi <anshurajbisoyi98@gmail.com>
Member
|
See linked issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2189.
Adds # isort: remove-redundant-aliases-off and
isort: remove-redundant-aliases-on action comments so selected
imports can retain explicit re-export aliases while still being sorted.
Each directive creates a sorting boundary, including with float_to_top.
The on directive restores the global setting. Directives inside strings
or sections disabled with # isort: off are ignored.
Regression tests cover ordinary and relative imports, LF and CRLF line
endings, repeated sorting, and restoring the global setting. The action
comment documentation describes the new behavior.
The directive names use redundant, matching the existing remove_redundant_aliases setting rather than the typo in the issue’s example.
Validation:
passed afterward.
Ruff reported two existing invalid noqa warnings in unchanged files.
Other Python versions, platforms, and integration tests were not tested.
AI assistance: Codex assisted with implementation, regression tests,
verification and documentation.