Fix/issue 2528 isort off import statements#2545
Open
harshith-coder wants to merge 2 commits into
Open
Conversation
added 2 commits
May 18, 2026 11:43
This fix addresses issue PyCQA#2528 where isort: off was not properly recognized when written without spaces (e.g., '#isort: off' or '# isort:off'). Changes: - Updated core.py to use flexible string matching for 'isort: off' and 'isort: on' - Now handles: '# isort: off', '#isort: off', and '# isort:off' variations - Added comprehensive regression tests for both import and from import statements - Verified that isort: off honors both plain imports and from imports equally Fixes: PyCQA#2528
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Handle isort comments with flexible spacing
Fixes #2528
Problem
The original code required exact string matching for
isort: offandisort: oncomments, causing them to fail when written without proper spacing:
#isort: off❌ (wasn't recognized)# isort:off❌ (wasn't recognized)# isort: off✅ (only this worked)Solution
Changed from exact string matching to flexible substring matching using the
inoperator.Verification
All variations now work correctly:
✅
#isort: off(no space after #)✅
# isort:off(no space after isort)✅
# isort: off(proper spacing)✅
# isort: on/# isort:on/#isort: onTesting