Fix bugs in normalize_line(), and with a 2.7x speedup#2381
Closed
kurtmckee wants to merge 4 commits intoPyCQA:mainfrom
Closed
Fix bugs in normalize_line(), and with a 2.7x speedup#2381kurtmckee wants to merge 4 commits intoPyCQA:mainfrom
normalize_line(), and with a 2.7x speedup#2381kurtmckee wants to merge 4 commits intoPyCQA:mainfrom
Conversation
These were identified but marked as `noqa`. Now the duplicates are simply removed.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2381 +/- ##
==========================================
- Coverage 99.16% 99.16% -0.01%
==========================================
Files 40 40
Lines 3101 3100 -1
Branches 680 680
==========================================
- Hits 3075 3074 -1
Misses 15 15
Partials 11 11 🚀 New features to boost your workflow:
|
916bc1c to
9aeaf27
Compare
DanielNoord
approved these changes
Mar 5, 2025
Contributor
Author
|
Thanks for the review, @DanielNoord! Is there anything preventing this PR (and the others you approved) from merging? |
Member
|
Mostly a review from @staticdev I think |
staticdev
requested changes
Mar 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following script was used for performance testing:
Fastest time with code in
main: 15.98 secondsFastest time with code in this PR: 5.82 seconds