Fixing carriage return error. Issue #326#328
Open
venturero wants to merge 2 commits intoPyCQA:mainfrom
Open
Conversation
fsouza
reviewed
Jun 2, 2025
Collaborator
fsouza
left a comment
There was a problem hiding this comment.
I think stripping it is fine. Can you add a test?
Comment on lines
536
to
539
| else: | ||
| # Eğer split işlemi beklenen şekilde çalışmazsa | ||
| indentation = '' | ||
| imports = line.replace('\r', '') |
Collaborator
There was a problem hiding this comment.
do you have an example of when this happens?
Author
There was a problem hiding this comment.
Is my pull request okay to merge? Do you have any other feedback for me? If so, I can update the code again. @fsouza
Author
I ran test_autoflake.py and this is the response i get: ..............'expand-star-imports' in the config file should be a boolean
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#326