Skip to content

Remove unused code for passing in a Codec object #1747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WyattBlue merged 1 commit into from
Feb 2, 2025
Merged

Remove unused code for passing in a Codec object #1747

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 3 additions & 11 deletions av/container/output.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,23 +51,15 @@ cdef class OutputContainer(Container):
Supports video, audio, and subtitle streams.

:param codec_name: The name of a codec.
:type codec_name: str | Codec
:type codec_name: str
:param dict options: Stream options.
:param \\**kwargs: Set attributes for the stream.
:rtype: The new :class:`~av.stream.Stream`.

"""

cdef const lib.AVCodec *codec
cdef Codec codec_obj

if isinstance(codec_name, Codec):
if codec_name.mode != "w":
raise ValueError("codec_name must be an encoder.")
codec_obj = codec_name
else:
codec_obj = Codec(codec_name, "w")
codec = codec_obj.ptr
cdef Codec codec_obj = Codec(codec_name, "w")
cdef const lib.AVCodec *codec = codec_obj.ptr

# Assert that this format supports the requested codec.
if not lib.avformat_query_codec(self.ptr.oformat, codec.id, lib.FF_COMPLIANCE_NORMAL):
Expand Down
Loading