Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incorrect av/__init__.pyi #1432

Closed
wants to merge 1 commit into from
Closed

Conversation

jlaine
Copy link
Member

@jlaine jlaine commented Jun 21, 2024

We do not need this type stub, since __init__.py is already a Python file. What's more the file is incorrect since it uses star imports, which the actual __init__.py does not.

We do not need this type stub, since `__init__.py` is already a Python
file. What's more the file is incorrect since it uses star imports,
which the actual `__init__.py` does not.
@WyattBlue
Copy link
Member

I'm glad that __init__.pyi can be removed. However, that does mean we need to write a stub for audio/fifo since mypy is checking __init__.py now. I actually went and already did that and applied your changes #1433, so we don't need this pull request now.

@WyattBlue WyattBlue closed this Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants