Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use av_guess_sample_aspect_ratio when reporting stream SAR #1425

Conversation

moonsikpark
Copy link
Contributor

When user requests stream's SAR, use the upstream's heuristic function (av_guess_sample_aspect_ratio()) to report it.

Resolves: #1267

@WyattBlue WyattBlue merged commit 3646f8d into PyAV-Org:main Jun 17, 2024
7 checks passed
@moonsikpark moonsikpark deleted the issue-1267-use-av-guess-sample-aspect-ratio branch June 17, 2024 09:39
@jlaine
Copy link
Member

jlaine commented Jun 28, 2024

I'd really prefer we don't merge any new code without the corresponding tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow way to get real aspect ratio
3 participants